Skip to content

dprint: skip unstable test to fix build on darwin#383569

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
kachick:fix-dprint-build
Feb 20, 2025
Merged

dprint: skip unstable test to fix build on darwin#383569
JohnRTitor merged 1 commit intoNixOS:masterfrom
kachick:fix-dprint-build

Conversation

@kachick
Copy link
Member

@kachick kachick commented Feb 20, 2025 •
edited
Loading

#382541 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc: @uncenter @khrj

Add a 👍 reaction to pull requests you find important.

@kachick kachick changed the title dprint: skip unstable test dprint: skip unstable test to fix build on darwin Feb 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 20, 2025
@kachick
Copy link
Member Author

kachick commented Feb 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383569

x86_64-linux

✅ 1 package built:
  • dprint

x86_64-darwin

✅ 1 package built:
  • dprint

aarch64-darwin

✅ 1 package built:
  • dprint

@kachick kachick marked this pull request as ready for review February 20, 2025 07:11
@kachick kachick requested a review from uncenter February 20, 2025 07:12
@nix-owners nix-owners bot requested a review from khrj February 20, 2025 07:19
@JohnRTitor JohnRTitor merged commit dfd9fbd into NixOS:master Feb 20, 2025
109 of 111 checks passed
@kachick
Copy link
Member Author

kachick commented Feb 20, 2025

Thanks for quick merging 🙏

@kachick kachick deleted the fix-dprint-build branch February 20, 2025 09:10
@khaneliman khaneliman mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uncenter uncenter Awaiting requested review from uncenter

@khrj khrj Awaiting requested review from khrj

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kachick @JohnRTitor